| 1 | This is the stable branch of Evolution. As a consequence, any |
|---|
| 2 | commit to this branch is subject to a patch review mechanism, as |
|---|
| 3 | defined by the following rules: |
|---|
| 4 | |
|---|
| 5 | 1. Every patch will be sent to evolution-patches@ximian.com in the |
|---|
| 6 | form of a unified diff (cvs diff -u). |
|---|
| 7 | |
|---|
| 8 | 2. Every patch will have to be on the list for at least 24 hours |
|---|
| 9 | before being committed. A week-end (Saturday+Sunday) counts as |
|---|
| 10 | a single 24-hour day. |
|---|
| 11 | |
|---|
| 12 | If a patch is by one of the core contributors of the module the |
|---|
| 13 | patch refers to and no-one speaks up against it in the 24 hour |
|---|
| 14 | period, the author can go ahead and commit the patch. |
|---|
| 15 | |
|---|
| 16 | On the other hand, patches by people who are not core |
|---|
| 17 | contributors of the module being patched will always have to be |
|---|
| 18 | confirmed as safe by one of the core contributors first. |
|---|
| 19 | |
|---|
| 20 | 3. As an exception to rule 2, if the patch gets approved by all |
|---|
| 21 | the core developers of the module before the 24-hour period, it |
|---|
| 22 | may get committed immediately. This doesn't apply to the |
|---|
| 23 | modules that have only one core maintainer though (e.g. the |
|---|
| 24 | shell); in that case, the patch will have to be approved by at |
|---|
| 25 | least one core developer of another module in order to be |
|---|
| 26 | committed before the 24-hour period. |
|---|
| 27 | |
|---|
| 28 | 4. Core contributors are required to give their opinion on the bug |
|---|
| 29 | in the 24 hour period. |
|---|
| 30 | |
|---|
| 31 | 5. Core module members are defined as follows: |
|---|
| 32 | |
|---|
| 33 | Addressbook: |
|---|
| 34 | Chris Lahey <clahey@ximian.com> |
|---|
| 35 | Chris Toshok <toshok@ximian.com> |
|---|
| 36 | Jon Trowbridge <trow@ximian.com> |
|---|
| 37 | |
|---|
| 38 | Calendar: |
|---|
| 39 | JP Rosevear <jpr@ximian.com> |
|---|
| 40 | Damon Chaplin <damon@ximian.com> |
|---|
| 41 | Rodrigo Moya <rodrigo@ximian.com> |
|---|
| 42 | |
|---|
| 43 | GAL: |
|---|
| 44 | ETable: |
|---|
| 45 | Chris Lahey <clahey@ximian.com> |
|---|
| 46 | Shortcut bar: |
|---|
| 47 | Damon Chaplin <damon@ximian.com> |
|---|
| 48 | Other GAL widgets: |
|---|
| 49 | Respective authors. |
|---|
| 50 | |
|---|
| 51 | GtkHTML: |
|---|
| 52 | Radek Doulik <rodo@ximian.com> |
|---|
| 53 | Larry Ewing <lewing@ximian.com> |
|---|
| 54 | |
|---|
| 55 | Importers: |
|---|
| 56 | Iain Holmes <iain@ximian.com> |
|---|
| 57 | |
|---|
| 58 | Mailer: |
|---|
| 59 | Jeffrey Stedfast <fejj@ximian.com> |
|---|
| 60 | Michael Zucchi <notzed@ximian.com> |
|---|
| 61 | |
|---|
| 62 | Shell: |
|---|
| 63 | Ettore Perazzoli <ettore@ximian.com> |
|---|
| 64 | |
|---|
| 65 | Summary: |
|---|
| 66 | Iain Holmes <iain@ximian.com> |
|---|
| 67 | |
|---|
| 68 | 6. Patches must be attached to bugs that are actually on the |
|---|
| 69 | Bugzilla, and the bug # must be specified when sending the patch |
|---|
| 70 | to the list. |
|---|
| 71 | |
|---|
| 72 | 7. Once the patch has been committed, it is the author's |
|---|
| 73 | responsibility to: |
|---|
| 74 | |
|---|
| 75 | - Close the corresponding bug on Bugzilla. |
|---|
| 76 | |
|---|
| 77 | - Write to the mailing list, replying to the original message |
|---|
| 78 | containing the patch to inform the other hackers that the |
|---|
| 79 | patch has been committed. |
|---|
| 80 | |
|---|
| 81 | - Update NEWS with a listing of the changes applied and |
|---|
| 82 | corresponding Ximian Bugzilla bug numbers. |
|---|
