Ticket #971 (closed defect: fixed)
logout() should check for a required reboot
| Reported by: | jdreed | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | Precise Release |
| Component: | -- | Keywords: | |
| Cc: | boojum | Fixed in version: | |
| Upstream bug: |
Description
When logging out via the GUI, /var/run/reboot_required is checked via /usr/lib/indicator-session/gtk-logout-helper. When logging out via "logout", it's not. It totally should be.
In other news, --kill and --silent are deprecated, according to gnome-session-save(1)
Change History
comment:2 follow-up: ↓ 3 Changed 12 years ago by jdreed
- Milestone changed from The Distant Future to Precise Release
I'm almost tempted to just go ahead and make the logout alias run /usr/lib/indicator-session/gtk-logout-helper and be done, and that will attempt to do a logout or reboot via DBus. Is there a good reason not to? Failing that, I think a small script that checks for /var/run/reboot_required, and pops up a zenity dialog asking people to reboot instead (with a timeout to just log out).
comment:3 in reply to: ↑ 2 Changed 12 years ago by kaduk
Replying to jdreed:
I'm almost tempted to just go ahead and make the logout alias run /usr/lib/indicator-session/gtk-logout-helper and be done, and that will attempt to do a logout or reboot via DBus. Is there a good reason not to? Failing that, I think a small script that checks for /var/run/reboot_required, and pops up a zenity dialog asking people to reboot instead (with a timeout to just log out).
I'm somehow not very excited by the prospect of running gtk-logout-helper ... maybe because DBus already gives us too much excitement as is?
comment:4 Changed 12 years ago by jdreed
- Status changed from new to committed
dotfiles/xsession break our no-x abstraction barrier. We should probably do something clever here. Fixed in dotfiles 10.0.31-0debathena1.
If we want to do this, I think we want some sort of helper app that we can run that optionally pops up a zenity dialog. Conditionals in tcsh aliases suck.