libpam-afs-session ships its own pam-auth-update config file

[broder]

As of libpam-afs-session 1.7-2 (in Squeeze), the package ships a pam-auth-update config file of its own. Which happens to install to the same path as the one we ship in debathena-pam-config - /usr/share/pam-configs/afs-session - creating a non-documented conflict.

Also, Russ's config file doesn't specify aklog_homedir, which would make us sad.

The solution, like we do for libpam-krb5, is to move our file to /usr/share/pam-configs/afs-session.debathena and DEB_REMOVE_FILES the one installed by libpam-afs-session.

We also need to do testing to make sure that the upgrading works correctly - honestly, I suspect it might not.

[lizdenys]

Fixed in r24885. geofft and I will test this to make sure upgrade paths don't break.

[lizdenys]

Upgrade paths do in fact break.

[geofft]

Specifically, upgrading breaks because the new libpam-afs-session installs before the new debathena-pam-config, and the former tries to overwrite this file in the latter and dpkg aborts unpacking the former. This could cause some issues in that we don't get a chance to run our package's maintainer scripts to clean up our mistake.

However! /usr/lib/python2.6/dist-packages/DistUpgrade/DistUpgradeController.py contains:

    # we run with --force-overwrite by default
    if not os.environ.has_key("RELEASE_UPGRADE_NO_FORCE_OVERWRITE"):
        logging.debug("enable dpkg --force-overwrite")
        apt_pkg.Config.Set("DPkg::Options::","--force-overwrite")

So it is entirely possible we will luck out, upstream's config file will force-overwrite ours, we'll divert upstream's, and all will be well with the world.

We should test this (I'll probably install a Lucid VM tomorrow afternoon) and call it resolved; it's possible we should figure out a better upgrade solution for Squeeze, but honestly Squeeze has only ever been half-supported and we've basically expected that upgrades may require manual intervention if Debian does things we weren't expecting, so I'm not entirely sure I care as long as we document it. If we release the package now, people running Lenny should have plenty of time to update, so it shouldn't make a lot of difference that Debian doesn't use the Ubuntu upgrader.

[geofft]

We do in fact luck out. dpkg overwrites the file and we just end up with afs-config.debathena in that directory as we wish.

I'll move this change to -proposed for non-Maverick distributions shortly.

[jdreed]

This has been working on my Lucid machine for a while without a problem. We should push it to proposed now (note that development only contains non-Maverick packages).

[amb]

I previously acked this on zephyr, so that's two. Just moved to -proposed.

[geofft]

This was moved into production a couple of days ago.